new source for population info#274
Closed
toxyl wants to merge 1 commit intoExpDev07:masterfrom
toxyl:patch-1
Closed
new source for population info#274toxyl wants to merge 1 commit intoExpDev07:masterfrom toxyl:patch-1
toxyl wants to merge 1 commit intoExpDev07:masterfrom
toxyl:patch-1
Conversation
I've compiled a new JSON for population data that I serve on my own server. The file is the same as the one provided by Geonames, but all populations have been updated to the numbers found on Wiki. Territories that have no permanent residents have a population of 0. And I've changed the key "geonames" to "data".
Kilo59
reviewed
Apr 11, 2020
Collaborator
Kilo59
left a comment
Kilo59
left a comment
There was a problem hiding this comment.
I don't think we want to change our population source without warning.
Should we build this into an optional query parameter?
However, if enough users are fine with this as it is I'll merge it.
So if anyone has a problem with this change please leave a comment on the PR or associated issue.
Author
I do like that idea because it also gives an easy way for a fallback in case a source goes down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've compiled a new JSON for population data that I serve on my own server. The file is the same as the one provided by Geonames, but all populations have been updated to the numbers found on Wiki. Territories that have no permanent residents have a population of 0. And I've changed the key "geonames" to "data".